Open
Conversation
|
This seems useful and, from a distance, seems to be a straightforward change: as long as we have the info that a signature item is a primitive, I don’t see any obstacle to typechecking aliases of it. |
added 2 commits
July 23, 2024 11:07
|
From a distance, this looks like a nice proposal that allows avoiding the error-prone duplication of external declarations. In favor! |
Author
|
Thanks for the review so far. I have implemented this and opened PR #13377 against the main OCaml repo. |
Contributor
|
Have you also considered extending the signature constraint mechanism |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a proposal for extending the syntax for
externalprimitives, making it easier to re-bind them under a different identifier, without reiterating the entire description (type, attributes, and symbols).Rendered version
(Thanks to @goldfirere for reviewing this RFC)