fix(rocq): add error handling and hints for Rocq modules duplication#13733
Open
Durbatuluk1701 wants to merge 2 commits intoocaml:mainfrom
Open
fix(rocq): add error handling and hints for Rocq modules duplication#13733Durbatuluk1701 wants to merge 2 commits intoocaml:mainfrom
Durbatuluk1701 wants to merge 2 commits intoocaml:mainfrom
Conversation
…raction and theory Signed-off-by: Will Thomas <30wthomas@gmail.com>
rlepigre-skylabs-ai
approved these changes
Mar 5, 2026
Collaborator
rlepigre-skylabs-ai
left a comment
There was a problem hiding this comment.
Thanks! This looks good to me. I left a few minor comments.
Signed-off-by: Will Thomas <30wthomas@gmail.com>
e0a025e to
739e5a3
Compare
rlepigre-skylabs-ai
approved these changes
Mar 5, 2026
Collaborator
rlepigre-skylabs-ai
left a comment
There was a problem hiding this comment.
Thanks for the changes, I don't have any further comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if a
rocq.theorystanza androcq.extractionstanza use the samemodule, we can encounter an error due to the attempted duplicate add:This PR addresses the issue by not performing an
add_exn, as well as addinghintsto the raised errors to provide more helpful guidance.Example Code
Not quite "minimal" example but hopefully good enough. Also note: this dune file will still not *fully* compile as there seems to be some issue with having a theory and extraction in the same folder?FactProg.v:FactExtr.v:dune: