Place default trace file in the build directory#13735
Open
vouillon wants to merge 3 commits intoocaml:mainfrom
Open
Place default trace file in the build directory#13735vouillon wants to merge 3 commits intoocaml:mainfrom
vouillon wants to merge 3 commits intoocaml:mainfrom
Conversation
Collaborator
|
@rgrinberg @shonfeder I think this can be considered a regression for 3.22. Probably best we include this fix for the release. |
rgrinberg
approved these changes
Mar 5, 2026
vouillon
force-pushed
the
trace
branch
2 times, most recently
from
ac1c30f to
1052c72
Compare
Member
|
Anything preventing us merging here? It looks like its been approved, and it is marked as blocking the release. |
Member
|
This PR should not block the release. There's no rush in merging it. I'd prefer if collaborators were to look at it more closely. |
Alizter
reviewed
Mar 9, 2026
Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
approved these changes
Mar 9, 2026
Collaborator
Alizter
left a comment
Alizter
left a comment
There was a problem hiding this comment.
If you can update the test I introduced with the changes, and modify the prose, also getting rid of the dune trace cat in the subdirectory, that would be great.
Rest looks good to me.
The default trace file path was hardcoded to `_build/trace.csexp`, resolved relative to the initial working directory. This meant it could end up outside the build directory when invoking dune from a subdirectory or when using a custom `--build-dir`. Use `Path.Build.root` to resolve the default trace file path, placing it correctly inside the workspace's build directory. `dune trace cat` and `dune trace commands` now also find the trace file at the workspace root. Signed-off-by: Jérôme Vouillon <jerome.vouillon@gmail.com>
`dune trace cat` from a subdirectory failed to find the trace file because `Workspace_root.create` short-circuits to CWD when running inside dune. Walk up from CWD looking for an existing `_build/trace.csexp` instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default trace file path was hardcoded to
_build/trace.csexp, resolved relative to the initial working directory. This meant it could end up outside the build directory when invoking dune from a subdirectory or when using a custom--build-dir.Use
Path.Build.rootto resolve the default trace file path, placing it correctly inside the workspace's build directory.dune trace catanddune trace commandsnow also find the trace file at the workspace root.