fix(path): use External.append_local in Build.to_string for consistent separators#14616
Merged
Conversation
Alizter
force-pushed
the
push-kqrplkwvnsus
branch
from
0bc2bef to
7a10027
Compare
nojb
approved these changes
May 28, 2026
nojb
left a comment
nojb
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
(Sorry for the delay, I had missed the notification for this PR.)
…t separators Replace Filename.concat with External.append_local when stringifying external build paths with a local suffix. This ensures forward slashes are used on all platforms, removing the need for conditional Windows/Unix test expectations. Signed-off-by: Ali Caglayan <alizter@gmail.com>
Alizter
force-pushed
the
push-kqrplkwvnsus
branch
from
7a10027 to
c35e6aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
Filename.concatwithExternal.append_localwhen stringifying external build paths with a local suffix. This ensures forward slashes are used on all platforms, removing the need for conditional Windows/Unix test expectations.Followup to path: appending local paths to external paths #14278.
Followed up by test: enable path tests on windows #14663
Contributes to Tests fail on Windows with: Cannot decode build prefix map #10176