Skip to content

fetch: Resolve file symlinks post fetch to enable caching#14871

Merged
Alizter merged 1 commit into
ocaml:mainfrom
punchagan:fix-14509
Jun 9, 2026
Merged

fetch: Resolve file symlinks post fetch to enable caching#14871
Alizter merged 1 commit into
ocaml:mainfrom
punchagan:fix-14509

Conversation

@punchagan

@punchagan punchagan commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

In #13792, we resolve directory symlinks in fetch targets. This commit extends the resolving to files too to enable caching for fetched sources.

Closes #14509

@Alizter Alizter requested a review from ElectreAAS June 2, 2026 12:57
@punchagan punchagan force-pushed the fix-14509 branch 2 times, most recently from ea34ff6 to d2cf50c Compare June 3, 2026 05:43
@punchagan punchagan marked this pull request as ready for review June 3, 2026 05:43
Comment thread src/dune_pkg/fetch.ml Outdated
Comment thread src/dune_pkg/fetch.ml Outdated
Comment thread src/dune_pkg/fetch.ml Outdated
Comment thread test/blackbox-tests/test-cases/pkg/fetch-cache-symlink.t Outdated
Comment thread test/blackbox-tests/test-cases/pkg/fetch-cache-symlink.t
Comment thread src/dune_pkg/fetch.ml
@Alizter Alizter self-assigned this Jun 4, 2026
@punchagan punchagan force-pushed the fix-14509 branch 2 times, most recently from 8850f98 to cfedfff Compare June 4, 2026 14:21
@Alizter Alizter added enhancement vendoring Libraries vendored into dune's own codebase and managing them shared-cache Shared artefacts cache package management Dune's package management — `(pkg)` stanza, lockdirs, `dune pkg` commands and removed vendoring Libraries vendored into dune's own codebase and managing them labels Jun 4, 2026

@Alizter Alizter left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@punchagan can you add a changes entry

In ocaml#13792, we resolve directory symlinks in fetch targets. This commit
extends the resolving to files too to enable caching for fetched sources.

Signed-off-by: Puneeth Chaganti <punchagan@muse-amuse.in>
@Alizter Alizter merged commit 950fc5a into ocaml:main Jun 9, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement package management Dune's package management — `(pkg)` stanza, lockdirs, `dune pkg` commands shared-cache Shared artefacts cache

Projects

None yet

Development

Successfully merging this pull request may close these issues.

packages with symlinks are refetched on every build

3 participants