Locate infix operators#1445
Closed
voodoos wants to merge 3 commits into
Closed
Conversation
Better late than never. ;-) |
Collaborator
Author
|
:-) |
voodoos
force-pushed
the
fix-949
branch
2 times, most recently
from
acfd919 to
e297d87
Compare
Collaborator
Author
|
Update: this PR has not been merged yet because we discovered some issues with the current approach. More work is needed. |
Collaborator
Author
|
Closing in favor of #1612 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TwoThree years laterThis fixes #949
In #949 the issue was identified as
Longident.parsereturning wrong lids for infix operators. A PR was merged in the compiler to expose the true longident parser.In fact this PR relies on
Longident.unflatten.~~This PR uses that parser to parse longidents produced by
reconstruct_identifier.However for usages of an infix operator the reconstructed identifier does not have surrounding parenthesis and the parser fails on these.
I chose to simply rerun the parser with added parenthesis if it fails, and fallback on
Longident.parseif it fails again.We probably could have a more deterministic style here, but I am not sure if that is worth the effort... @trefis ?~~