Saved parts testing#2060
Open
trefis wants to merge 3 commits into
Open
Conversation
This reverts commit b4521e2cb7250f49b63e8a037a1130ff9cb1ca95.
Contributor
Author
|
Oh, one last thing: typemod tends to pass a I have neither checked nor thought hard about it. Have fun. |
xvw
approved these changes
Apr 17, 2026
Collaborator
xvw
left a comment
There was a problem hiding this comment.
this PR is for illustration purposes ... though if you want to be a bit defensive against future compiler updates, I suggest you reproduce and adapt the latest test (which shows when things blow up) for the other parts of the codebase which currently do not "save parts" on success.
We probably want to have a ticket to track this.
Collaborator
|
There is a weird indentation issue in the test on the macos runner.... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some investigations into merlin's saved parts motivated by the review of ocaml/ocaml#14241 .
A very short summary of a couple of long discussions:
Some key points: