Conversation
Collapse three redundant switch blocks in validatePrivateKey() into one.
Show "Private key stored" with a Replace button instead of loading the PEM back into the editor. Matches password auth behavior where the credential is not re-displayed.
Owner
|
Thanks for the PR @afds 🥇. Will be pushing out an app store release for today |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Key changes
SSHKeyImporter— parses OpenSSH PEM format for Ed25519, P-256, P-384; handles mpint sign-byte strippingConnectionEditorView— private key paste UI with live validation, error hints, and copy-public-key buttonSessionManager— loads key from Keychain and buildsNIOSSHPrivateKeyfor connect/resume flowsMoshSessionState— persists auth method type to support key-based session resumptionTests
Test cases in
SSHKeyImporterTestscovering synthetic keys, realssh-keygenkeys, mpint edge cases, and error paths for all three key types.