fix: validate NANO_DRIVE after sourcing /etc/nanobsd.conf#59
Open
jailedengineer wants to merge 1 commit into
Open
fix: validate NANO_DRIVE after sourcing /etc/nanobsd.conf#59jailedengineer wants to merge 1 commit into
jailedengineer wants to merge 1 commit into
Conversation
The upgrade script sources /etc/nanobsd.conf and immediately uses
NANO_DRIVE without checking it was actually set. A corrupt, truncated
or empty config file would leave NANO_DRIVE unset, tripping set -u
later in the script with a less informative error.
Applies the same defensive pattern used in tenant's get_next_id() for
sourcing legacy /etc/jail.lastid: use ${var:-} fallback when checking,
fail early with a clear error message.
Low practical risk on a healthy system since /etc/nanobsd.conf is
generated by the build process, but defensive enough to catch the
case where the file was tampered with or partially written during
recovery operations.
Owner
|
But the "set -u" should catches those already: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upgrade script sources /etc/nanobsd.conf and immediately uses NANO_DRIVE without checking it was actually set. A corrupt, truncated or empty config file would leave NANO_DRIVE unset, tripping set -u later in the script with a less informative error.
Applies the same defensive pattern used in tenant's get_next_id() for sourcing legacy /etc/jail.lastid: use ${var:-} fallback when checking, fail early with a clear error message.
Low practical risk on a healthy system since /etc/nanobsd.conf is generated by the build process, but defensive enough to catch the case where the file was tampered with or partially written during recovery operations.