Open
Conversation
ocornut
reviewed
Jun 16, 2021
Str.h
Outdated
|
|
||
| void Str::replace(const char* find, const char* repl) | ||
| { | ||
| STR_ASSERT(Owned == 1); |
Owner
There was a problem hiding this comment.
Can take ownership after we know that replacements are needed (ideally without a double rewrite)
ocornut
reviewed
Jun 16, 2021
| for (char* p = Data, *end = Data + length(); p != NULL && p < end;) | ||
| { | ||
| p = (char*)memmem(p, end - p, find, find_len); | ||
| if (p) |
Owner
There was a problem hiding this comment.
Maybe avoid looping fully if no match or end when last match?
Contributor
Author
There was a problem hiding this comment.
That was already the case. memmem() would return NULL and loop would not continue due to p != NULL check in for
Owner
There was a problem hiding this comment.
By definition if memmem returns null it means the string has been read entirely. Whereas you already have a match counter you can use to early out.
…locating too small buffer when buffer resize is needed.
Owner
|
When |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.