Conversation
|
Can you consider merging #967 before cutting the release? |
|
I'm reticent in including this because it copies some code that's under a different and incompatible license. It's very short and it's the logical thing to do, but still it's the same code. Something similarish (bigger chunks of code) happened with Eio: ocaml-multicore/eio#352 (comment) I can think of a few ways solve this, but none seem very satisfactory:
If you see another alternative or if you can make a good case for one of those, maybe I can merge the PR or another equivalent PR. |
|
There were a few comments from February on the ocamllabs slack channel suggesting the code snippet was small enough to be merged. |
|
Now that 5.1.0~rc1 is released, I'd like to give it a try, but we currently can't test because of our dependency on Lwt. Looking forward to a release with compatibility with OCaml 5.1. Thank you! |
The release should be merged soon. The PR for it is ocaml/opam-repository#24213 |
Version 5.7.0
Don't merge for now