Use caml_unix_get_sockaddr instead of its legacy name get_sockaddr#1100
Merged
raphael-proust merged 2 commits intoocsigen:masterfrom Feb 23, 2026
Merged
Use caml_unix_get_sockaddr instead of its legacy name get_sockaddr#1100raphael-proust merged 2 commits intoocsigen:masterfrom
raphael-proust merged 2 commits intoocsigen:masterfrom
Conversation
Add support for OCaml 5.5
Contributor
Author
|
Some extra reasoning for the way i've done things in this PR: ocaml/ocaml#14516 (comment) |
Collaborator
|
There's on 4.14 investigating |
Collaborator
|
fix I think at some point I need to revisit all the defs and such, there might be some common patterns that would be better pulled together in a single file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for OCaml 5.5 to lwt due to the change of definition of caml_unix_get_sockaddr in ocaml/ocaml#14310 which triggers the following failure: