Skip to content

Fix greedy capture of positional arguments when names are identical #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sea-odoo merged 1 commit into from
Apr 28, 2026
Merged

Fix greedy capture of positional arguments when names are identical #154

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions odev/common/commands/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,14 +323,13 @@ def _rescue_positional_from_unknown_flag(
if not raw_val:
continue

try:
val_idx = argv_list.index(raw_val)
indices = [i for i, x in enumerate(argv_list) if x == raw_val]
for val_idx in indices:
if val_idx > 0 and argv_list[val_idx - 1] in unknown:
flag_idx = unknown.index(argv_list[val_idx - 1])
unknown.insert(flag_idx + 1, raw_val)
setattr(arguments, arg_name, None)
except ValueError:
pass
break

@classmethod
def parse_arguments(cls, argv: Sequence[str]) -> Namespace:
Expand Down
Loading