[FIX] common: auto-import plugin common/ submodules on load#158
Open
eacm-odoo wants to merge 1 commit into
Open
[FIX] common: auto-import plugin common/ submodules on load#158eacm-odoo wants to merge 1 commit into
common/ submodules on load#158eacm-odoo wants to merge 1 commit into
Conversation
Modules placed under a plugin's `common/` directory were never imported when the plugin loaded: only the plugin package and its `commands/` were. Anything in `common/` that relied on import-time side effects (subclass registration, decorators, etc.) stayed inert, so plugin extensions could silently fail to apply depending on import order. Walk `common/` after importing the plugin and import each submodule explicitly so its side effects run.
eacm-odoo
force-pushed
the
eacm-vscode-issue
branch
from
e7070fc to
ac0dcf3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modules placed under a plugin's
common/directory were never imported when the plugin loaded: only the plugin package and itscommands/were. Anything incommon/that relied on import-time side effects (subclass registration, decorators, etc.) stayed inert, so plugin extensions could silently fail to apply depending on import order.Walk
common/after importing the plugin and import each submodule explicitly so its side effects run.Linked Issues
Link the issues that this PR solves, if any:
Compliance
docsdirectoryrequirements.txtfile, if any