Implement own visualization module with Sankey and waterfall#35
Implement own visualization module with Sankey and waterfall#35fwitte wants to merge 11 commits into
Conversation
|
For testing:
|
|
I would appreciate if this PR would come to fruition, as it would be nice to not lose the sankey diagram with the TESPy version bump and accompanied change to exerpy for heatpumps. Let me know if you need any help. |
|
Pushed some fixes on top: removed |
Maybe that is what caused #36?
I would put them as optional, but I'd leave final decision up to you
I think we should make some more testing with graphs for other systems. Especially heat pumps are interesting, when exergy flow is negative on some edges and see how that looks like. For unit tests I would suggest following situations:
|
|
@fwitte Regarding your points: #36: Not caused by the Mixer issue. That bug only dropped the deaerator's E_D link in the diagram, the analysis totals were always correct. I could reproduce #36 exactly: in your CGAM snippet, stream Dependencies: moved to an optional Tests: implemented your list as synthetic-cycle unit tests: pure-fluid closed cycle, mixtures, splitting on/off, E_PH/E_CH and E_T/E_M/E_CH splits, fuel/product with inputs and outputs, and negative flows. On "does it make sense for loss?": yes, the ccpp cooling water does exactly that (fresh water in, warm water out), covered too. Negative links are currently dropped silently. I'll think of this last thing next week. Then I would close this PR. I hope it is fine @jfreissmann |
This PR
I created this with the help of Claude and need to do some thorough testing, I think a meeting to discuss it would be nice @sertomas.