Skip to content

feat: implement % variable expansion in daemon exec commands and paths#2619

Merged
oferchen merged 1 commit intomasterfrom
feature/variable-expansion-exec-logformat
Mar 10, 2026
Merged

feat: implement % variable expansion in daemon exec commands and paths#2619
oferchen merged 1 commit intomasterfrom
feature/variable-expansion-exec-logformat

Conversation

@oferchen
Copy link
Owner

Summary

  • Adds PathExpansionContext and expand_daemon_path() for single-character %-escape expansion (%P, %m, %u, %a, %h, %p, %%) in daemon path and exec command strings
  • Wires expansion into early_exec, pre_xfer_exec, and post_xfer_exec command strings before shell execution
  • Adds expand_log_file_path() for per-module log file path expansion (ready for wiring)
  • 27 new tests covering all escape characters, edge cases, and combined patterns

Test plan

  • All 55 variable expansion tests pass locally
  • Clippy passes with zero warnings
  • CI fmt+clippy passes
  • CI nextest passes across stable/beta/nightly
  • Windows and macOS builds pass

@github-actions github-actions bot added the enhancement New feature or request label Mar 10, 2026
Add PathExpansionContext and expand_daemon_path() for single-character
%-escape expansion (%P, %m, %u, %a, %h, %p, %%) in daemon path and
exec command strings. Wire into early_exec, pre_xfer_exec, and
post_xfer_exec command expansion before shell execution.
@oferchen oferchen force-pushed the feature/variable-expansion-exec-logformat branch from 702e4a6 to 85e5d6d Compare March 10, 2026 03:27
@oferchen oferchen merged commit 089b415 into master Mar 10, 2026
31 checks passed
@oferchen oferchen deleted the feature/variable-expansion-exec-logformat branch March 10, 2026 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant