test(web): wrap test harness in MetadataProvider to match production#17
Merged
Merged
Conversation
main.tsx wraps the app in DemoProvider > MetadataProvider, but the app.test.tsx render helpers only wrapped with DemoProvider. Since e490d91 added useMetadata() to Sidebar, the routed app threw "useMetadataContext must be used within MetadataProvider" in tests; the error boundary swallowed the tree and the first-load assertion failed. CI has been red on main since that commit. Mirror the production provider nesting in both render sites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI has been red on
mainsincee490d91("add global metadata visibility toggle"). That commit addeduseMetadata()toSidebar, but the test render helpers inapp.test.tsxonly wrapped withDemoProvider— notMetadataProvider.Result: the routed app throws
useMetadataContext must be used within MetadataProviderin tests, the route error boundary swallows the tree, and the first-load empty-state assertion fails.Fix
Mirror the production provider nesting from
main.tsx(QueryClient > Demo > Metadata > Router) in both render sites inapp.test.tsx. No app code changes.Verification
make check— lint + typecheck + 11/11 tests pass locally.Follow-up
Branch protection let three consecutive red runs land on
main. Worth enabling a required green-CI gate (tracked separately).