fix: harden token and URL transport security#22
Merged
Conversation
* fix: harden token and URL handling * test: restore full web test suite --------- Co-authored-by: batumilove <batumilove@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tightens how tokens and URLs are handled across web and desktop:
Web (
lib/security.ts+ wiring):isSecureTokenTransport— API tokens are only sent over HTTPS, or HTTP to loopback (localhost/127.0.0.1).SettingsFormandWebhookManagersurface a clear error otherwise.isHttpOrHttpsUrl,isLoopbackUrl).Desktop (Tauri):
http://*— plaintext HTTP is restricted to localhost/127.0.0.1; remote hosts must use HTTPS.null):connect-src 'self' http://localhost:* http://127.0.0.1:* https:,object-src 'none', etc.Net effect: the app won't transmit a bearer token over cleartext to a remote host. A remote Honcho served over plain HTTP must move to HTTPS (or be reached via localhost).
Credit
Cherry-picked from @batumilove's fork, authorship preserved. Thanks @batumilove!
Verification
make check(lint + typecheck + 17/17 tests) andcargo-checkboth pass locally.