Skip to content

Rewrite review guideline for custom_lint rule development#58

Merged
offich merged 1 commit intodevelopfrom
dev/to-custom-lint
May 2, 2026
Merged

Rewrite review guideline for custom_lint rule development#58
offich merged 1 commit intodevelopfrom
dev/to-custom-lint

Conversation

@offich
Copy link
Copy Markdown
Owner

@offich offich commented May 2, 2026

Description

Rewrite docs/dev/review-guideline.md to be relevant to this repository's actual domain — custom lint rule development with custom_lint_builder — replacing the previous content that was mistakenly written for DevTools Extension development.

What was done

  • Rewrote docs/dev/review-guideline.md with a checklist and examples covering:
    • LintCode definition correctness (static const requirement for // ignore: suppression)
    • AST visitor selection and node type coverage
    • False positive prevention (guard conditions, type checking)
    • Error reporting accuracy
    • Memory safety (no cached AST node references)
    • Rule registration and testing requirements
    • Common pitfalls with Bad/Good code examples

What was NOT done

  • Did not change any lint rule implementations
  • Did not change CI or workflow configuration

Operation Confirmation

Prerequisites & Steps

No special steps required — documentation only.

Notes & Related URLs

N/A

@offich offich self-assigned this May 2, 2026
@offich offich merged commit 7618ef3 into develop May 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant