fix: handle closure labels in nav validation#19
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes the navigation:validate command so it can process navigation items whose label is a PHP Closure (dynamic labels) without crashing, and adds a regression test to cover that scenario.
Changes:
- Treat
Closurelabels as a safe placeholder string when constructing the validation “path” output. - Add a feature test ensuring closure labels don’t cause
navigation:validateto error.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Commands/ValidateNavigationCommand.php |
Prevents string interpolation on Closure labels by substituting a placeholder label for path construction. |
tests/Feature/ValidateCommandTest.php |
Adds a regression test covering closure-based labels in navigation config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.