feat: both config and db flags#13
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds per-flag driver routing so an application can mix config-driven (read-only) flags with database-driven (runtime-mutable) flags via a new database_flags config option, with tests and documentation updates.
Changes:
- Introduces
PerFlagDriverand wires it intoToggleServiceProviderwhendatabase_flagsis configured. - Adds overlap validation that logs a warning when the same flag appears in both
flagsanddatabase_flags. - Adds feature tests and updates package docs/config comments to describe the new behavior.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/ToggleServiceProvider.php |
Creates PerFlagDriver when database_flags is set; adds overlap validation warning on boot. |
src/Drivers/PerFlagDriver.php |
Implements routing logic per-flag and merges all() results across drivers. |
config/toggle.php |
Documents config-driven vs database-driven flags and introduces database_flags config key. |
README.md |
Documents per-flag driver routing usage and resolution rules. |
tests/Feature/PerFlagDriverTest.php |
Adds coverage for config/db routing, precedence, all(), and overlap warning logging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.