fix: support invited by in waitlist invite#17
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR extends the waitlist invitation flow so callers can pass invitation options (notably invited_by) through Waitlist::invite() / WaitlistService::invite(), enabling correct attribution and exposing additional invitation fields while keeping existing call sites backwards compatible.
Changes:
- Added optional
$options = []argument toWaitlistService::invite()and forwarded/merged it intoInviteOnly::invite(...). - Added feature tests validating
invited_bypass-through and authenticated-user fallback behavior. - Updated README to document the new
Waitlist::invite($entry, $options)usage and signature.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/WaitlistService.php |
Accepts and forwards invitation options; introduces invited_by fallback behavior. |
tests/Feature/WaitlistTest.php |
Adds regression tests for invited_by being passed and defaulted. |
README.md |
Documents new invite(..., $options) capability and updates the public API signature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow invited_by (and other options) to be passed through Waitlist::invite()
WaitlistService::invite() now accepts an optional array $options = [] second argument that's forwarded to InviteOnly::invite(). This unblocks setting invited_by (the field was always being written as null) and also exposes role, metadata, and expires_at to callers without changing existing call sites.
Why
Inviting from the waitlist always resulted in invitations.invited_by = null, since the service had no parameter for it and never consulted auth(). The fix belongs in the package — every consumer benefits, and no app-side wrapper is needed.
Behavior