Skip to content

feat: one commit for release update#21

Merged
shavonn merged 1 commit into
mainfrom
feat/one-commit-for-release-update
Apr 3, 2026
Merged

feat: one commit for release update#21
shavonn merged 1 commit into
mainfrom
feat/one-commit-for-release-update

Conversation

@shavonn
Copy link
Copy Markdown
Contributor

@shavonn shavonn commented Apr 3, 2026

No description provided.

Copilot AI review requested due to automatic review settings April 3, 2026 17:58
@shavonn shavonn merged commit 485a2fb into main Apr 3, 2026
2 checks passed
@shavonn shavonn deleted the feat/one-commit-for-release-update branch April 3, 2026 17:58
@github-actions github-actions Bot mentioned this pull request Apr 3, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the release PR creation script to produce a single consolidated commit for release-related changes, instead of committing the version bump and changelog update separately.

Changes:

  • Remove the separate git commit calls from the version bump and changelog sections.
  • Add a single “commit all staged release changes” step with a unified commit message.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -72,15 +72,18 @@ main() {
if [[ -f package-lock.json ]] && ! git diff --staged --quiet package-lock.json 2>/dev/null; then
Copy link

Copilot AI Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conditional that decides whether to git add package-lock.json is checking the staged diff (git diff --staged --quiet package-lock.json). At this point the lockfile hasn’t been staged yet, so this will typically report “no staged changes” and skip adding the lockfile even when npm version modified it. Use a working-tree/index check (e.g., git diff --quiet -- package-lock.json or git status --porcelain -- package-lock.json) so changed lockfiles are reliably included in the release commit.

Suggested change
if [[ -f package-lock.json ]] && ! git diff --staged --quiet package-lock.json 2>/dev/null; then
if [[ -f package-lock.json ]] && ! git diff --quiet -- package-lock.json 2>/dev/null; then

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants