password visibility toggle

[lumpy72006]

Fixes offspot/dashboard#46

[rgaudin]

Thank you ;

First of all, the UI doesn't look right: field is not placed correctly.

Also, when hovering the toggle button, it disapears, which is annoying because most of the time, you want to see what you type(d) but keep your pointer on the icon to easily revert to hidden. screenshot doesn't show the pointer but it's on the icon

Finally, it would be better if this could be more reusable (probably useful elsewhere like on the SSID)

• store the SVGs in files
• work of classes and match elements relatively
• also place the JS part outside body block (there's a javascript block for that.

[rgaudin]

Convention is also I think to have the icon inside the field. If inline SVG is easier, you can make it reusable by creating a template for the complete field.

[lumpy72006]

Thank you ;

First of all, the UI doesn't look right: field is not placed correctly.

Also, when hovering the toggle button, it disapears, which is annoying because most of the time, you want to see what you type(d) but keep your pointer on the icon to easily revert to hidden. screenshot doesn't show the pointer but it's on the icon

Could you tell me your OS + browser and whether you're in dark mode or not? This is what mine looks like and the toggle button doesn't disappear on hover (I'm on debian bookworm)

[rgaudin]

Firefox 147 on macOS. You should check your browser's console as the style is not applied properly: not using font, button style is off, colors as well.

[lumpy72006]

Firefox 147 on macOS. You should check your browser's console as the style is not applied properly: not using font, button style is off, colors as well.

I added CDNs to raw_base.html and it showed me what you had albeit the colors being off. This is what I have now after working on it