Add cfg illlumos in addition to solaris#49
Open
papertigers wants to merge 1 commit intoogham:masterfrom
Open
Conversation
Author
|
@ogham is it possible to get this merged in so we no longer need to have a patched |
|
Ping here for my metadata agent work @ogham |
|
This now block the installation of cargo-make |
This was referenced May 22, 2022
|
Hi @ogham, could we get this pull requested integrated and a new version released? Various downstream crates depend on it, and we'd really really like to get it working on illumos systems. Thanks! |
|
Since this project is unmaintained, I forked to https://github.com/rustadopt/uzers-rs where I for example merged this PR and maintain it from now on. It's also available in v0.11.2 on https://crates.io/crates/uzers |
|
@gierens Thank you I'll have a go at bringing it to projects that I get build errors from. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I initially noticed this was broken when trying to install
fd-findon OmniOS viacargo install fd-find.illumos is its own distinct rust target now. Building with rust-users on a platform such as OmniOS or SmartOS that uses the illumos target via rustup is currently broken. Adding the proper cfg parameters fixes this. Note I chose to ignore the lint warning as it's not related to this change.
Test output: