fish_right_prompt: Make it optional#25
Open
fidencio wants to merge 1 commit intooh-my-fish:masterfrom
Open
Conversation
Allow users to easily decide whether or not the `fish_right_prompt` should be displayed. The current way to do so is creating an empty `fish_right_prompt` function in `~/.config/fish/functions/fish_mode_prompt.fish`, which although is very well documented and the default way to do so, is less handy than having an option on the theme to do so. Fixes: oh-my-fish#24 Signed-off-by: Fabiano Fidêncio <fabiano@fidencio.org>
fidencio
force-pushed
the
wip/make_displaying_right_prompt_configurable
branch
from
9060429 to
415ec2f
Compare
Contributor
Author
|
/cc @scorphus Pablo, I must say I, myself, am not sure about this one. On one hand we have a well documented way to do this globally, on the other hand backing providing a way to do this via the theme allows the users to backup a single configuration file. I'm totally fine on just closing the PR (and the associated issue) in case this is not the way to proceed. |
scorphus
approved these changes
May 29, 2022
| set -g theme_stash_indicator yes | ||
| ``` | ||
|
|
||
| Hide the right prompt: |
Member
There was a problem hiding this comment.
Suggested change
| Hide the right prompt: | |
| Disable the right prompt: |
|
|
||
| Hide the right prompt: | ||
| ``` | ||
| set -g theme_hide_right_prompt yes |
Member
There was a problem hiding this comment.
Suggested change
| set -g theme_hide_right_prompt yes | |
| set -g theme_disable_right_prompt yes |
| @@ -1,4 +1,12 @@ | |||
| # You can override some default options with config.fish: | |||
| # | |||
| # set -g theme_hide_right_prompt yes | |||
Member
There was a problem hiding this comment.
Suggested change
| # set -g theme_hide_right_prompt yes | |
| # set -g theme_disable_right_prompt yes |
| # set -g theme_hide_right_prompt yes | ||
|
|
||
| function fish_right_prompt | ||
| if test "$theme_hide_right_prompt" = 'yes' |
Member
There was a problem hiding this comment.
Suggested change
| if test "$theme_hide_right_prompt" = 'yes' | |
| if test "$theme_disable_right_prompt" = 'yes' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow users to easily decide whether or not the
fish_right_promptshould be displayed.
The current way to do so is creating an empty
fish_right_promptfunction in
~/.config/fish/functions/fish_mode_prompt.fish, whichalthough is very well documented and the default way to do so, is less
handy than having an option on the theme to do so.
Fixes: #24
Signed-off-by: Fabiano Fidêncio fabiano@fidencio.org