splus v2: agent-led, engine on tap (v0.9.0)#7
Merged
Conversation
Flip splus from engine-led (push a finding list through a gate) to agent-led (a curious reviewer pulls deterministic signal on demand). The engine becomes a toolbelt, a per-repo contract is read first, and a reviewer's diligence compounds. Engine on tap (P0): - new `inspect` subcommand (definition/callers/blast_radius/complexity/exports/ imports) reusing the existing analysis tier; exposed as MCP `inspect` + `floor`. - `review` recast to orient (inject contract + return floor + drive), back-compat. - import resolver now understands TS ESM `.js` specifiers, so callers/blast radius resolve on modern TS (fixes the existing blast-radius collector too). splus.md — the contract, read first (P1): - parser + repo/~/.splus layering; injected at kickoff; binding mute:/skip: rules enforced and reported; `preferences` tool; `prefs` skill. Compounding memory (P2): - `recall`/`note` + accept-stores-memory, embedding match over memory.json on the existing Embedder seam (a transformer model drops in unchanged). Skills (prime): - review orchestrator that fans out fresh, unbiased sub-agents (finder != verifier) and degrades to a sequential pass; investigate/lenses/verify/dispatch + prefs. All green: 60 engine tests, 24 TS tests, --locked build, single-file bundle parses, no warnings. Docs (README, TOOLS.md, CHANGELOG) updated; dead splus-review badge removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pivot
splus flips from engine-led (push a finding list through a gate) to agent-led (a curious reviewer pulls deterministic signal on demand). The engine becomes a toolbelt, a per-repo contract is read first, and a reviewer's diligence compounds across sessions.
What's in this PR (all wired, no dead code)
P0 — Engine on tap
inspectengine subcommand + MCP tool: ask one deterministic question —definition·callers·blast_radius·complexity·exports·imports. Reuses the existing analysis tier (graph/symbols/scip/complexity); no new analysis, just addressable.floortool — re-ground on the deterministic finding set for any scope, no directive.reviewrecast to orient — injects the contract, returns the floor, drives investigate → verify → report → teach. Backward compatible..jsspecifiers (import … from "./x.js"forx.ts) — callers/blast radius now resolve on modern TS, fixing the existing blast-radius collector too. (Dogfood:inspect callers hashEmbeddercorrectly finds its 2 real callers.)P1 —
splus.md, read first~/.spluslayering; injected at kickoff; bindingmute:/skip:rules enforced and reported (never silent).preferencestool +prefsskill. A realsplus.mdships for this repo.P2 — Compounding memory
recall/note, andacceptnow stores a recallable memory. Embedding match over.splus-cache/memory.jsonon the existingEmbedderseam.Skills (prime)
revieworchestrator that fans out fresh, unbiased sub-agents per unit (finder ≠ verifier) and degrades to a sequential pass where sub-agents aren't available;investigate/lenses/verify/dispatchreferences;prefs.Verification
cargo build --locked(0.9.0) · single-filemcp.cjsbundle parses · no warnings.docs/TOOLS.md, CHANGELOG. Removed the deadsplus-reviewbadge (that workflow was deleted in ci: bump actions off deprecated Node 20; drop self-review workflow #6).Deliberately deferred (to keep this PR prime, not half-built)
Honest scoping per the "no dead code" bar — the fan-out works today via the skill + the P0/P2 tools, so none of these are dangling:
Embedderseam; swapping in a model needs to be verified against the single-file offline bundle, which I didn't want to ship unverified.reporttemplate still works.Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.