feat: skills-first delivery, contract-trace directive, SPLUS.md (v0.9.2)#9
Merged
Conversation
The protocol no longer depends on agents reading MCP tool descriptions: install.sh now installs the review skills into every detected agent (Claude Code ~/.claude/skills, Codex ~/.codex/prompts, OpenCode ~/.config/opencode/command), with the canonical copy at ~/.splus/skills, refreshed on every `splus update`. Release tarballs ship skills/. Bench-proven review lessons land in the agent path: - `review` returns a deterministic CHANGED SYMBOLS block (engine exports ∩ diff hunks, via new shared changedExportedSymbols/diffText) - the directive gains a TRACE CONTRACTS stage (return shape on every path → open every caller → report each mismatch) and an anti-checklist clause banning generic hardening nits - the same disciplines are encoded in skills/review (contract-drift lens) Also: - SPLUS.md replaces splus.md as the review contract (no fallback) - bench triage pipeline: second contract-tracing discovery lens, merged + deduped; claude -p client fails closed on is_error and unparseable forced-tool JSON; signal budget 3 → 4 per file - @splus/shared tests wired into pnpm -r test (had no test script) - drop unused @splus/triage dep from @splus/mcp (bench-only by design) - bump all versions to 0.9.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Skills-first delivery. The review protocol no longer depends on agents reading MCP tool descriptions.
install.shinstalls the skills into every detected agent — Claude Code (~/.claude/skills/splus-review,splus-prefs), Codex (~/.codex/prompts/splus-review.md), OpenCode (~/.config/opencode/command/splus-review.md) — canonical copy at~/.splus/skills, refreshed on everysplus update. Release tarballs now shipskills/.Contract-trace review protocol (bench-proven on Martian cal.com PRs):
reviewreturns a deterministic CHANGED SYMBOLS block (engine exports ∩ diff hunks) via newchangedExportedSymbols/diffTextin@splus/sharedskills/review(new contract-drift lens)SPLUS.mdreplacessplus.mdas the per-repo contract (no fallback).Bench pipeline (bench-only, MCP never calls it): second contract-tracing discovery lens with dedup;
claude -pclient fails closed onis_error/unparseable tool JSON; signal budget 3→4.Hygiene:
@splus/sharedtests wired intopnpm -r test(package had no test script —splusMd.test.tsnever ran in CI); dead@splus/triagedep dropped from@splus/mcp; all versions → 0.9.2.Verification
mcp.cjscarries 0.9.2; engine reports 0.9.2Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.