fix: make model_info field optional in ShowResponse#609
Open
yurekami wants to merge 1 commit intoollama:mainfrom
Open
fix: make model_info field optional in ShowResponse#609yurekami wants to merge 1 commit intoollama:mainfrom
yurekami wants to merge 1 commit intoollama:mainfrom
Conversation
The `model_info` field in ShowResponse was defined with `Field(alias='model_info')` without a default value, making it required even though the type is `Optional`. This caused a ValidationError when the `/api/show` endpoint omits the `model_info` field, which happens with certain cloud models like: - glm-4.7:cloud - qwen3-next:80b-cloud - deepseek-v3.2:cloud The fix adds `default=None` to the Field definition, making the field truly optional (can be absent from input data) and defaulting to `None`. Fixes ollama#607 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
please merge - the issue breaks compatibility between the current Ollama server application and the ollama-python library |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShowResponsevalidation fails when the/api/showendpoint omits themodel_infofielddefault=Noneto themodelinfoField definition to make it truly optionalmodel_infoProblem
The
model_infofield inShowResponsewas defined as:In Pydantic,
Optional[...]means the value can beNone, butField()without adefaultstill makes the field required (must be present in input). This caused aValidationErrorwhen the server response doesn't includemodel_info.Affected cloud models include:
glm-4.7:cloudqwen3-next:80b-clouddeepseek-v3.2:cloudSolution
Changed to:
This makes the field truly optional - it can be absent from the input data and will default to
None.Test plan
test_show_response_without_model_info- verifies ShowResponse can be created without model_info fieldtest_show_response_with_model_info- verifies ShowResponse still works when model_info is provided🤖 Generated with Claude Code