fix(xcelium): handle xrun_options passed from FuseSoC command line - #537
fix(xcelium): handle xrun_options passed from FuseSoC command line#537tymonx wants to merge 1 commit into
Conversation
e86bc65 to
6e1dd42
Compare
|
Hmm... it's a clever solution, but xrun_options should really be a list and I think we better fix that bug instead. I didn't catch that when I did the initial review. |
|
@olofk Alternatively we could introduce a new type def _build_parser(self, backend_class, edam):
typedict = {
"bool": {"type": str2bool, "nargs": "?", "const": True},
"file": {"type": str, "nargs": 1, "action": FileAction},
"int": {"type": int, "nargs": 1},
"str": {"type": str, "nargs": 1},
"real": {"type": float, "nargs": 1},
}I can create an issue and PR in the FuseSoC project to add the The |
|
For now, I have moved this PR to the Draft state. I will create a separate PR in the FuseSoC project olofk/fusesoc#790 to add the |
|
If this will be merged olofk/fusesoc#791 then this PR can be simplified by replacing the |
6e1dd42 to
5ce08f8
Compare
5ce08f8 to
b2e0af2
Compare
|
@olofk Ready for review and approve. Sorry for the mess with the I have added only the |
Closes #530
This PR:
--xrun_options="<args>"from thefusesoccommand line interface to the EdalizexceliumbackendCorrect way to enable handling list for an option: olofk/fusesoc#791 (comment)