Skip to content

fix(xcelium): handle xrun_options passed from FuseSoC command line - #537

Open
tymonx wants to merge 1 commit into
olofk:mainfrom
tymonx:fix/xcelium-xrun-options
Open

fix(xcelium): handle xrun_options passed from FuseSoC command line#537
tymonx wants to merge 1 commit into
olofk:mainfrom
tymonx:fix/xcelium-xrun-options

Conversation

@tymonx

@tymonx tymonx commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Closes #530

This PR:

  • Fixes passing the --xrun_options="<args>" from the fusesoc command line interface to the Edalize xcelium backend

Correct way to enable handling list for an option: olofk/fusesoc#791 (comment)

@tymonx
tymonx force-pushed the fix/xcelium-xrun-options branch from e86bc65 to 6e1dd42 Compare June 24, 2026 18:42
@olofk

olofk commented Jun 30, 2026

Copy link
Copy Markdown
Owner

Hmm... it's a clever solution, but xrun_options should really be a list and I think we better fix that bug instead. I didn't catch that when I did the initial review.

@tymonx

tymonx commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

@olofk Alternatively we could introduce a new type list or args. But this is not supported on the FuseSoC side:

https://github.com/olofk/fusesoc/blob/f15e1c8a76815c4f391231dd0e743e2b683c6b45/fusesoc/edalizer.py#L335

    def _build_parser(self, backend_class, edam):
        typedict = {
            "bool": {"type": str2bool, "nargs": "?", "const": True},
            "file": {"type": str, "nargs": 1, "action": FileAction},
            "int": {"type": int, "nargs": 1},
            "str": {"type": str, "nargs": 1},
            "real": {"type": float, "nargs": 1},
        }

I can create an issue and PR in the FuseSoC project to add the list or args type and later update this PR.

The str type is definitely not clear here because core files are using YAML array with strings and tool backend is expecting list of arguments (aka list of strings).

@tymonx

tymonx commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

For now, I have moved this PR to the Draft state. I will create a separate PR in the FuseSoC project olofk/fusesoc#790 to add the list type and refactor this PR to use that type instead of the str type.

@tymonx

tymonx commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

If this will be merged olofk/fusesoc#791 then this PR can be simplified by replacing the str type with the list type.

@tymonx
tymonx force-pushed the fix/xcelium-xrun-options branch from 6e1dd42 to 5ce08f8 Compare June 30, 2026 22:29
@tymonx tymonx changed the title fix(xcelium): handle xrun_options as string passed from FuseSoC command line fix(xcelium): handle xrun_options passed from FuseSoC command line Jun 30, 2026
@tymonx
tymonx force-pushed the fix/xcelium-xrun-options branch from 5ce08f8 to b2e0af2 Compare July 2, 2026 12:18
@tymonx
tymonx marked this pull request as ready for review July 2, 2026 12:20
@tymonx

tymonx commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

@olofk Ready for review and approve. Sorry for the mess with the list type. I followed your comment from the FuseSoC project: olofk/fusesoc#791 (comment)

I have added only the "list": True to the xrun_options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(xcelium): cannot use the fusesoc run --xrun_options from command line because option is a string type

2 participants