flows: support env vars in hook scripts#543
Open
ThVerg wants to merge 1 commit into
Open
Conversation
The flow API silently dropped the 'env' key of EDAM hook scripts (marked FIXME in add_scripts), while the legacy tool API honors it. Pass the env dict through EdaCommands' existing variables mechanism, which emits an 'env KEY=value' prefix in the generated Makefile. Add a test that a pre_build hook with env ends up prefixed in the Makefile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flow API silently drops the
envkey of EDAM hook scripts —Edaflow.add_scripts()has the support commented out with a# FIXME : Add env varsmarker, while the legacy tool API honorsenvin_run_scripts().EdaCommands.Commandalready has avariablesmechanism that the make build runner turns into anenv KEY=valuecommand prefix, so this just passesscript.get("env", {})through it and removes the FIXME and the commented-out code.Includes a test verifying that a
pre_buildhook withenv: {FOO: bar}producesenv FOO=bar echo helloin the generated Makefile (205 tests pass).