tests: add tests for untested flows and flow-API tools#545
Open
ThVerg wants to merge 1 commit into
Open
Conversation
Add tests using the golden-file harness for the previously untested flow-API tools ghdl, sv2v, vpr, icetime and sandpipersaas, and for the previously untested flows icestorm, vivado, vpr, gowin and efinity. The flow test fixture gains a paramtypes argument (defaulting to the previous behaviour) since the gowin flow rejects vlogparam/vlogdefine parameters. The f4pga flow is left untested since its configure_flow still returns the legacy list-of-tuples flow description, which the current Edaflow base class cannot consume.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds tests for the flow-API tools and flows that currently have no test coverage, using the existing golden-file harness (
tests/edalize_tool_common.py/tests/edalize_flow_common.py, references regenerated withGOLDEN_RUN).New flow-API tool tests (
tests/test_tool_*.py+ goldens undertests/tools/):--stdoverride via analyze_options, verilog mode, toplevel with library)New flow tests (
tests/test_flow_*.py+ goldens undertests/flows/):Notes:
tests/edalize_flow_common.pygains an optionalparamtypesargument (default unchanged) because the gowin flow rejects vlogparam/vlogdefine parameters.work_rootstring instead of using the shared fixture, since the tool embedswork_rootin the generated Makefile (and string-concatenates it, so it must not be a Path).flows/f4pga.py. Itsconfigure_flowstill returns the legacy list-of-tuples flow description, which the currentEdaflowbase class cannot consume (AttributeError: 'list' object has no attribute 'get_nodes'), so it cannot be instantiated without a library fix.Full suite passes: 231 tests (204 before, 27 added).