scene.coordinateTransformations path optional for input and output#149
scene.coordinateTransformations path optional for input and output#149will-moore wants to merge 4 commits into
Conversation
Automated Review URLs |
cc78660 to
408e44d
Compare
408e44d to
565a6cd
Compare
|
@will-moore I think that's ok. Could you add the json of the scene file that was previously failing to the |
|
Additionally we could restructure the |
|
@jo-mueller I am reluctant to refactor the schemas too much as I'm not very familiar with all the moving parts and relationships. Takes a while to get my head around them! I've added a validator test in description above |
fair :) I sent you a PR to add the tested (repviously invalid) json to the tests here. looks good otherwise from my side. |
tests: add json to example to CI
Fixes #148 (hopefully!)
The scene uses
coordinate_transformations.schema#/$defs/coordinateTransformationfor transforms, which only requirestypeto be specified for transforms.The scene.schema then adds
inputandoutputobjects, both of which only requirename.This leaves
pathas optional for bothinputandoutputobjects (instead of beingrequiredforinputobjects).To test, we can use the validator modified at ome/ome-ngff-validator#80 to accept a URL to a specific schemas location. Using that to point at this branch, we can see that the sample from #148 above is passing validation (just looking at the top-level
scene, not the child images).https://deploy-preview-80--ome-ngff-validator.netlify.app/?source=https://livingobjects.ebi.ac.uk/idr/zarr/test-data/v0.6.dev4/idr0050/4995115_output_to_ms.zarr&schemas=https://raw.githubusercontent.com/will-moore/ngff-spec/refs/heads/scene_coordinateTransformations_input_path_optional/schemas/