Added UTF-8 encoding to writers for cross-OS compatibility#119
Merged
Conversation
Collaborator
|
Thanks, Jens! This looks pretty straightforward (and useful) so I'll try to find a minute this week to review it properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I am mainly using Windows I ran into issues with special characters like
µin Key-Value pairs andüäöß(german special characters) in names of images/datasets.The error was:
Setting the encoding to UTF-8 for the writing should alleviate this.
I also set
newline=''for the csv.writer as AI was pointing me towards it (https://docs.python.org/3/library/csv.html the footnote at the bottom) as an additional safety net