Added IMS support by sureshmarikkannu · Pull Request #343 · omec-project/pcf

sureshmarikkannu · 2026-06-06T06:21:24Z

No description provided.

Copilot

Pull request overview

This PR appears to adjust PCC/QoS/TC rule handling to better support IMS-related media flows by consolidating MediaSubComponents into combined PCC rules, changing several rule/ID formatting behaviors, and altering SM Policy update notification behavior/logging.

Changes:

Changed PCC/QoS/TC/PacketFilter ID generation to return plain numeric strings.
Added combined MediaSubComponent handling to create/merge PCC rules using aggregated FlowInfos, with significantly expanded logging.
Adjusted SM policy update notification dispatch/logging, including appending /update to the SMF notification URI.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
util/pcc_rule.go	Changes PCC/QoS/TC/PackFilt ID string formats and minor QoS construction refactor.
producer/policyauthorization.go	Adds combined MediaSubComponent handling, alters SMF update payload construction, and introduces extensive new logging.
internal/notifyevent/send_smpolicy_update.go	Improves failure log detail for SM policy update notifications.
internal/notifyevent/dispatcher.go	Modifies SM policy update notification URI handling (adds `/update`).
context/ue.go	Refactors IPv4 SM policy lookup and adds matching/not-found logs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>

Copilot

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 4 comments.

Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>

gab-arrobo · 2026-06-12T07:56:42Z

@sureshmarikkannu you need to rebase this PR

sureshmarikkannu · 2026-06-12T08:13:19Z

@sureshmarikkannu you need to rebase this PR

done

gab-arrobo · 2026-06-17T23:37:24Z

@sureshmarikkannu, please resolve conflicts (I think the go.mod/sum changes are not needed anymore) and rebase. Thanks!

Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>

sureshmarikkannu · 2026-06-18T04:54:32Z

@sureshmarikkannu, please resolve conflicts (I think the go.mod/sum changes are not needed anymore) and rebase. Thanks!

done

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.

Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.

Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>

Copilot

Pull request overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

sureshmarikkannu requested a review from a team June 6, 2026 06:21

gab-arrobo requested a review from Copilot June 6, 2026 14:15

Copilot started reviewing on behalf of gab-arrobo June 6, 2026 14:15 View session

Copilot AI reviewed Jun 6, 2026

View reviewed changes

sureshmarikkannu added 3 commits June 8, 2026 23:34

Added IMS support

76061d8

Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>

Address copilot comments

7d193d6

Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>

Use openapi 2.1.0 version

32843b8

Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>

sureshmarikkannu force-pushed the ims-support branch from 4add6ba to 32843b8 Compare June 8, 2026 18:04

gab-arrobo requested changes Jun 8, 2026

View reviewed changes

Comment thread context/ue.go Outdated

Comment thread internal/notifyevent/dispatcher.go Outdated

Comment thread util/pcc_rule.go

Comment thread util/pcc_rule.go

Comment thread util/pcc_rule.go Outdated

Comment thread producer/policyauthorization.go Outdated

Address review comments

dadd1f4

Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>

gab-arrobo requested a review from Copilot June 9, 2026 18:27

Copilot started reviewing on behalf of gab-arrobo June 9, 2026 18:28 View session

Copilot AI reviewed Jun 9, 2026

View reviewed changes

Comment thread producer/policyauthorization.go

Comment thread producer/policyauthorization.go

Comment thread producer/policyauthorization.go

Comment thread internal/notifyevent/dispatcher.go

Address comments

42dfbf2

Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>

gab-arrobo requested changes Jun 11, 2026

View reviewed changes

sureshmarikkannu added 2 commits June 11, 2026 23:09

Merge branch 'main' into ims-support

53e0a51

Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>

Address review comments

3eded66

Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>

Merge branch 'main' into ims-support

7c34db3

Merge branch 'main' into ims-support

27533f0

Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>

gab-arrobo requested a review from Copilot June 18, 2026 05:41

Copilot started reviewing on behalf of gab-arrobo June 18, 2026 05:41 View session

Copilot AI reviewed Jun 18, 2026

View reviewed changes

Comment thread producer/policyauthorization.go Outdated

Comment thread producer/policyauthorization.go Outdated

Comment thread producer/policyauthorization.go

Comment thread internal/notifyevent/dispatcher.go Outdated

Address copilot comments

4fca969

Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>

gab-arrobo requested a review from Copilot June 18, 2026 15:17

Copilot started reviewing on behalf of gab-arrobo June 18, 2026 15:18 View session

Copilot AI reviewed Jun 18, 2026

View reviewed changes

Comment thread producer/policyauthorization.go

Comment thread producer/policyauthorization.go Outdated

Comment thread producer/policyauthorization.go

Comment thread internal/notifyevent/dispatcher.go

Comment thread producer/policyauthorization.go Outdated

Copilot AI reviewed Jun 24, 2026

View reviewed changes

Comment thread producer/policyauthorization.go Outdated

Address copilot comments

cb80801

Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>

gab-arrobo requested a review from Copilot June 25, 2026 05:10

Copilot started reviewing on behalf of gab-arrobo June 25, 2026 05:10 View session

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Comment thread producer/policyauthorization.go Outdated

Comment thread producer/policyauthorization_test.go Outdated

Address review comments

6e38079

Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>

sureshmarikkannu requested a review from Copilot June 25, 2026 06:02

Copilot started reviewing on behalf of sureshmarikkannu June 25, 2026 06:03 View session

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Comment thread util/pcc_rule.go

Comment thread producer/policyauthorization.go

sureshmarikkannu requested a review from Copilot June 25, 2026 06:13

Copilot started reviewing on behalf of sureshmarikkannu June 25, 2026 06:14 View session

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Comment thread producer/policyauthorization.go Outdated

Comment thread producer/policyauthorization.go

Comment thread producer/policyauthorization.go

sureshmarikkannu requested a review from Copilot June 25, 2026 06:27

Copilot started reviewing on behalf of sureshmarikkannu June 25, 2026 06:28 View session

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Comment thread producer/policyauthorization.go Outdated

Comment thread producer/policyauthorization.go

Comment thread producer/policyauthorization.go

Comment thread producer/policyauthorization.go

Comment thread producer/policyauthorization.go

Address review comment

14b6240

Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>

sureshmarikkannu requested a review from Copilot June 25, 2026 07:07

Copilot started reviewing on behalf of sureshmarikkannu June 25, 2026 07:07 View session

Copilot AI reviewed Jun 25, 2026

View reviewed changes

Comment thread producer/policyauthorization.go Outdated

Comment thread internal/notifyevent/dispatcher.go

Comment thread producer/policyauthorization.go Outdated

Comment thread producer/policyauthorization.go

Comment thread producer/policyauthorization.go

gab-arrobo reviewed Jun 25, 2026

View reviewed changes

Comment thread producer/policyauthorization.go

sureshmarikkannu added 2 commits July 1, 2026 06:42

Merge remote-tracking branch 'origin/main' into ims-support

f53fc70

Address review comments

c89591c

Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>

Copilot AI review requested due to automatic review settings July 1, 2026 14:50

Copilot started reviewing on behalf of sureshmarikkannu July 1, 2026 14:50 View session

Copilot AI reviewed Jul 1, 2026

View reviewed changes

Comment thread producer/policyauthorization.go

Comment thread producer/policyauthorization.go

Comment thread producer/policyauthorization.go Outdated

Comment thread internal/notifyevent/dispatcher.go

sureshmarikkannu added 2 commits July 1, 2026 08:34

Change log level to debug

1460681

Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>

update VERSION file

01d48c9

Signed-off-by: Marikkannu, Suresh <suresh.marikkannu@intel.com>

Copilot AI review requested due to automatic review settings July 2, 2026 11:48

Copilot started reviewing on behalf of sureshmarikkannu July 2, 2026 11:48 View session

Copilot AI reviewed Jul 2, 2026

View reviewed changes

Comment thread producer/policyauthorization.go

Comment thread producer/policyauthorization.go

Comment thread producer/policyauthorization.go

Uh oh!

Conversation

sureshmarikkannu commented Jun 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gab-arrobo commented Jun 12, 2026

Uh oh!

sureshmarikkannu commented Jun 12, 2026

Uh oh!

gab-arrobo commented Jun 17, 2026

Uh oh!

sureshmarikkannu commented Jun 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment