This repository was archived by the owner on Dec 5, 2021. It is now read-only.
[pull] develop from ethereum-optimism:develop #573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull
bot
added
merge-conflict
…18733) * feat: update withdrawal command wip * test: add E2E test for withdrawal proof from game extraData Add TestSuperRootWithdrawalFromGameExtraData that proves withdrawals by reading super root proof directly from SuperFaultDisputeGame.extraData() instead of requiring supervisor-rpc. Also adds DSL support via ProveFromGameExtraData() method. * fix: reorder withdrawal tests to avoid l1Origin stuck issue AdvanceTime() in shared orchestrator tests leaves L2 sequencer's l1Origin stuck, causing subsequent tests to fail with "L2 Deposit never found". Fix by: - Moving TestProveFromGameExtraData first (Go runs tests in file order) - Simplifying it to only test prove step (no AdvanceTime needed) - Full withdrawal flow still tested by TestSuperRootWithdrawal * refactor: remove supervisor-based withdrawal proof flow --dispute-game is now required for super root withdrawals. * refactor: unify proveWithdrawalTransaction to single 4-param signature Replace two proveWithdrawalTransaction overloads (6-param for super roots, 4-param for output roots) with a single unified 4-param function. When superRootsActive=true, the contract now calls game.rootClaimByChainId(chainId) internally instead of requiring callers to pass SuperRootProof. Changes: - Remove 6-param proveWithdrawalTransaction and related errors - Update _proveWithdrawalTransaction to use rootClaimByChainId - Remove OptimismPortal_WrongProofMethod, InvalidSuperRootProof, InvalidOutputRootIndex, InvalidOutputRootChainId errors - Update tests to use unified signature with mocked rootClaimByChainId BREAKING: Callers using 6-param signature must update to 4-param. * chore: remove dead code from withdrawal proof refactor Remove unused code after unifying proveWithdrawalTransaction: - ProveWithdrawalParametersSuperRoots function and struct (no callers) - SupervisorClient interface in withdrawals/utils.go (no callers) - supervisorClient field from StandardBridge (unused after refactor) - Unused imports: hexutil, eth, rollup, depset * chore: fix ci checks for interface, linter, and snapshots * chore: fix go lint warnings Remove goimports formatting issues and delete unused functions. * chore: remove redundant ProveFromGameExtraData test and methods After removing supervisor-based withdrawal proof flow, TestProveFromGameExtraData became redundant as Prove() and ProveFromGameExtraData() now do the same thing. TestSuperRootWithdrawal already covers the full prove + finalize flow. * docs: remove outdated super roots section from withdrawal README The --dispute-game and --rollup.config flags no longer exist. The prove command now works uniformly for all proof types. * chore: remove unused DecodeSuperRootProof and related types DecodeSuperRootProof has zero callers. Remove it along with SuperRootProofOutputRoot and SuperRootProof types, and the encoding/binary import they required.
* Interop Activity * Add Verified Database and Function Implementations * Tests ; Cleanup ; VerifiedAt integration * Use BBolt DB * PR updates * lint and logic fix * ethereum.NotFound when not yet verified * fix tests * Expand test coverage * only create interop activity if enabled * downgrade log to Debug * update go.mod * PR Comments * Fix Tests
* Enable UInt64 lint check and fix remaining violations. * Fix op-chain-ops fuzz tests * Fix safemath_test * Return error instead of panicing if array length is not a uint64 * Review feedback * Fix newly introduced violations.
) * ci: migrate docker builds to GitHub Actions (except op-deployer) Migrate Docker image builds from CircleCI to GitHub Actions for all images except `op-deployer`. ## Changes **GitHub Actions:** - Build all images (except op-deployer) in GHA with multi-arch support (amd64/arm64) - Add scheduled daily builds at 2 AM UTC - Add cross-platform verification job - Push to `images` registry instead of `oss` - Rename jobs: `local` → `build`, `fork` → `build-fork` **CircleCI:** - Keep `op-deployer` builds in CircleCI (main, release, scheduled workflows) - Remove all other images from docker-build matrices ## Why op-deployer stays in CircleCI `op-deployer` embeds compiled Solidity contract artifacts via `go:embed`. The CircleCI pipeline has an existing `contracts-bedrock-build` job that compiles these artifacts and passes them via workspace attachment. Replicating this in GHA requires changes to the Dockerfile build process that need more work. * ci: add merge_group trigger support to branches workflow Add merge_group event to triggers and build job condition so the workflow runs properly when PRs go through the merge queue.
* historical proof support for devstack * refactored to use `DEVSTACK_L2EL_KIND` and `L2ELOption` * removed op-reth-with-proof from `DEVSTACK_L2EL_KIND` * added todo issue link --------- Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
* feat(ci): add op-rbuilder and kona-node to docker-bake Add docker-bake.hcl targets for the Rust-based images: - op-rbuilder: uses existing Dockerfile in op-rbuilder/ - kona-node: uses kona's generic app dockerfile Update branches.yaml workflow to build these images in the matrix. Add separate cross-platform check for Rust images since they use ENTRYPOINT instead of CMD. * fix: correct dockerfile path for op-rbuilder target
* feat(contracts): add OPCMV2 batch upgrade invariant test Implements test to enforce the invariant that approximately 5 upgrade operations can be executed within a single transaction. - Add BatchUpgrader helper contract for batching 5 sequential upgrades - Add test_batchUpgrade_multipleChains_succeeds() test that: - Deploys 5 separate chains using opcmV2.deploy() - Prepares upgrade inputs for each chain - Executes all 5 upgrades in a single transaction via BatchUpgrader - Verifies all chains upgraded successfully (version and impl checks) This validates that OPCMV2's upgrade mechanism is efficient enough for batch operations across multiple chains. * test(contracts): increase batch test to 15 * fix: correct natspec comment * test(contracts): skip batch upgrade test in coverage mode * Add LibString import and enhance batch upgrade error handling * fix: forge fmt * refactor(test): move batch upgrade test to non-forked test contract The test_batchUpgrade_multipleChains_succeeds test deploys fresh chains and doesn't require forked network state. Moved it to a new test contract OPContractsManagerV2_BatchUpgrade_Test that inherits from OPContractsManagerV2_TestInit instead of the fork-only OPContractsManagerV2_Upgrade_TestInit. Changes: - Created OPContractsManagerV2_BatchUpgrade_Test contract - Moved test from OPContractsManagerV2_Upgrade_Test - Replaced disputeGameFactory queries with makeAddr() calls - Test now runs without FORK_TEST=true requirement * feat: allow Feat* prefix in test validation and rename batch upgrade test Updates test validation to accept middle parts starting with `Feat*` as valid test contract patterns. This allows feature test contracts that don't require corresponding source functions. Also renames OPContractsManagerV2_BatchUpgrade_Test to OPContractsManagerV2_FeatBatchUpgrade_Test to follow the new pattern.
Bumps the number of retries for OPCM registry queries to get rid of CI flakes.
Add configuration flags to the txmgr to make the blob tip cap mechanism configurable: - `txmgr.blob-tip-cap-dynamic`: Enable/disable using the dynamic blob tip oracle (vs static tip cap) for blob transactions only (default: false) - `txmgr.blob-tip-cap-percentile`: Configure the percentile to use when calculating the suggested blob tip cap (default: 60, range: 1-100) - `txmgr.blob-tip-cap-range`: Configure the number of recent blocks to analyze for the distribution (default: 20) These flags only affect blob transactions. Regular (non-blob) transactions continue to use the standard `txmgr.min-tip-cap` / `txmgr.max-tip-cap` settings. The `txmgr.max-tip-cap` setting is still enforced even when using dynamic blob tip cap. Also adds RPC methods (Get/SetBlobTipCapDynamic) to toggle the setting at runtime. Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
* feat: have ASR only use IDisputeGame * fix: remove old test
…18879) * kona: add reproducible-prestate justfile target * kona: build docker images from local context and remove asterisc support * kona: Remove version.json and simplify justfile * make reproducible-prestate in main Makefile builds kona also * kona: just clean should not remove bin dir * Improve output of main reproducible-prestate make target * Fix kona prestate loading in acceptance tests * kona: build in docker instead of pulling from upstream * Fix location of kona prestate * Update build-prestates.sh * Refactor build-prestates.sh to build both prestate types on all tags * Remove legacy kona versions that aren't in standard-prestates.toml * Remove additional mise install of just * Hardcode rust version for kona reproducible build * build-prestates.sh: only build prestates that match each tag
* devstack: Ensure Supernode is exposed in the sysgo system * review comments * ensure TestCLAdvanceMultiple passes
* feat: semgrep rule preventing initialize without owned check Introduces a new semgrep rule that prevents initialize functions on the L1 side that aren't tagged with the assertOnlyProxyAdminOrProxyAdminOwner assertion. * fix: remove test because semgrep is bad * fix: more semgrep issues
* feat: have graphite review storage layout Updates the graphite rules so that the robot will review any changes to the storage layout and try to warn developers for unsafe changes. * fix: handle contract deletions or movements
Adds a few expanded comments on aspects about the migration function.
Adds a test to confirm that OPCMv2 is able to execute upgrades even while paused.
…9021) * fix: add code lenght check for ReadSuperchainDeployment and tests * test: fix populate superchain v2 error string
* fix: generic revert error in UpgradeOPChain script * fix: generic revert error in UpgradeSuperchainConfig script
* Supernode: Interop Acceptance Testing * merge devstack setups * cleanup * Rework Tests * use system provided supernode client ; lint * Update test name * lint ; address ai comment * fix test requires * use superRoot for more tests ; assert pre/post activation more directly
* feat: Game Args struct instead of raw bytes (#813) * feat: allows a more structured json for gameArgs in upgrade config instead of requiring raw bytes * chore: reorganize structs declarations, move structs out of the EncodedUpgradeInputV2 func * chore: add edge case check for encoded config length * test: add expected encoding values * chore: remove comment * test: update tests * fix: tests (#823) * fix: add revert case for invalid game type (#825) * fix: add revert case for invalid game type * refactor: better error msg --------- Co-authored-by: niha <205694301+0xniha@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )