OMI_physics_shape: Use sub-JSON instead of a flat hierarchy#176
Merged
Conversation
aaronfranke
force-pushed
the
physics-shape-sub-doc
branch
from
June 29, 2023 22:26
4436a8b to
e12d5ef
Compare
aaronfranke
marked this pull request as ready for review
June 29, 2023 22:26
robertlong
approved these changes
Jun 29, 2023
robertlong
left a comment
robertlong
left a comment
Member
There was a problem hiding this comment.
Reviewed in the gltf-extensions meeting. Looks good 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes OMI_physics_shape to use sub-JSON instead of a flat hierarchy.
To be clear, I am still of the opinion that this is worse than a flat hierarchy. However, others desire the sub-JSON approach, and I want to move forward with something people can agree on.