fix(security): enforce portal auth validation on set-password flow#100
Merged
JanZachmann merged 1 commit intoomnect:mainfrom Feb 18, 2026
Merged
Conversation
When portal token validation fails (e.g. wrong signature, insufficient role), the OIDC user remains in localStorage, allowing manual navigation to /set-password which has no auth middleware — effectively bypassing the portal auth gate. Two-layer fix: - Backend: validate_portal_token() stores a session flag on success; set_password() rejects requests without the flag (401). - Frontend: Callback.vue clears the OIDC user from localStorage on validation failure so the router guard blocks manual navigation. Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When portal token validation fails (wrong signature, insufficient role, etc.), the OIDC user remains in localStorage. This allows manual navigation to
/set-password, which has no auth middleware — bypassing the portal auth gate entirely.Two-layer fix:
validate_portal_token()stores aportal_validatedsession flag on success;set_password()rejects requests without the flag (HTTP 401)Callback.vueclears the OIDC user from localStorage on validation failure so the router guard blocks manual navigation