fix(docker): resolve git revision in Dockerfile#104
Open
JanZachmann wants to merge 2 commits intoomnect:mainfrom
Open
fix(docker): resolve git revision in Dockerfile#104JanZachmann wants to merge 2 commits intoomnect:mainfrom
JanZachmann wants to merge 2 commits intoomnect:mainfrom
Conversation
… build arg The GIT_SHORT_REV build arg defaulted to "unknown" and was never passed by the Concourse CI pipeline, so production images shipped without the actual git revision. Add a dedicated git-info Dockerfile stage that extracts the revision from .git directly, making the build self-contained. Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
…ocker Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git-infoDockerfile stage that extractsGIT_SHORT_REVfrom.gitdirectly, replacing the fragileARG GIT_SHORT_REV="unknown"defaultGIT_SHORT_REVbuild-arg plumbing frombuild-and-deploy-image.shReason
The Concourse CI pipeline does not pass
BUILD_ARG_GIT_SHORT_REV, so all production Docker images were built with"unknown"as the git revision. The newgit-infostage makes the build self-contained — no caller needs to pass the build arg.Verification
docker buildx build -f Dockerfile .without--build-arg GIT_SHORT_REVembeds the actual git short revcargo build -p omnect-uistill resolves the git rev via thebuild.rsfallbackscripts/build-and-deploy-image.shworks without changes to callers