Skip to content

refactor: type unification, build optimization, and comment cleanup#93

Merged
JanZachmann merged 23 commits intoomnect:mainfrom
JanZachmann:refactor/ux
Feb 9, 2026
Merged

refactor: type unification, build optimization, and comment cleanup#93
JanZachmann merged 23 commits intoomnect:mainfrom
JanZachmann:refactor/ux

Conversation

@JanZachmann
Copy link
Contributor

@JanZachmann JanZachmann commented Feb 4, 2026

Summary

This PR performs a significant refactoring of the omnect-ui codebase, focusing on type unification, consistent naming conventions, build optimizations, and documentation cleanup.

Key changes:

  • Consistent Naming: Switched the Model and shared types to camelCase for consistency between the Rust Core (WASM) and the Vue frontend.
  • Type Unification: Moved request/response structs to the Core and unified validation rules using serde_valid. Standardized types to use Ipv4Addr and updated backend services to use these shared types.
  • ODS Data Parsing: Introduced specialized DTOs in the Core to isolate external WebSocket wire formats from internal domain models.
  • Build Optimization: Optimized Vite build chunks for Vue and Vuetify and moved vue-router to runtime dependencies.
  • Comment Cleanup: Stripped historical context markers (e.g., "previously", "was"), technical debt notes, and high-priority tags (BUG, TODO, etc.) from comments across 33 files.
  • Documentation: Updated project-context.md with new project structure and rules.

Reason

  • Maintainability: Unifying types between Core and Backend reduces code duplication and the risk of synchronization errors.
  • Readability: Standardizing on camelCase and removing historical context from comments makes the codebase cleaner and easier to navigate.
  • Performance: Build optimizations reduce the production bundle size and improve load times.

Verification

  • Unit Tests: Verified that cargo test --features mock and cargo test -p omnect-ui-core pass.
  • E2E Tests: Playwright test suites were updated to match the new naming conventions and verified.
  • Linting: Verified with cargo clippy and bun run lint.

Signed-off-by: Jan Zachmann 50990105+JanZachmann@users.noreply.github.com

@JanZachmann
docs: update project structure in project-context.md
b6557af 
Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
@JanZachmann
docs: add rule to update project structure in project-context.md
56c6e1e 
Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
@JanZachmann
refactor(ui): unify camelCase naming and improve ODS data parsing
b4ff9e0 
- Switched Model and shared types to camelCase for consistent frontend/WASM communication.
- Introduced ODS DTOs in Core to isolate external WebSocket wire format from internal domain models.
- Replaced netmask dropdown with a subnet mask text field and added CIDR/Subnet conversion utilities.
- Implemented client-side validation for IP and Subnet mask in the network form.
- Unified event handling for ODS updates using raw JSON strings and a specialized parsing macro.
- Updated Playwright tests to match the new camelCase properties and UI changes.

Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
@JanZachmann
refactor: unify shared types between core and backend
f67b539 
- Moved request and response structs (NetworkConfigRequest, SetPasswordRequest, etc.) to omnect-ui-core.
- Added serde_valid dependency to core for unified validation rules.
- Standardized shared types to use std::net::Ipv4Addr where appropriate.
- Enabled #[serde(rename_all = "camelCase")] on shared types for UI consistency.
- Updated backend services and API handlers to use core types, eliminating duplication.
- Resolved clippy warnings and fixed type conversion issues in core logic.

Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
@JanZachmann
chore(ui): optimize build chunks and silence large chunk warnings
1df35d2 
- Moved vue-router to runtime dependencies.
- Configured Vite to split Vue and Vuetify into separate manual chunks.
- Increased chunkSizeWarningLimit to 1000kB to accommodate modern UI framework sizes.

Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
@JanZachmann
docs: clean up code comments by removing historical context and markers
333a267 
- Removed technical debt notes and future intent comments.
- Stripped historical context markers (e.g., "was", "previously", "until now").
- Removed high-priority markers like BUG, FIX, REGRESSION, TODO, and CRITICAL from comments and test titles.
- Excised environment-specific build instructions and internal implementation details from docstrings and code comments.
- Standardized comments to focus on current behavior rather than implementation history.

Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
@JanZachmann
docs: update project structure in project-context.md
e929cc3 
Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
@JanZachmann
refactor(ui): enhance network configuration visualization and layout
ed79514 
- Optimized horizontal space by reducing excessive margins on main pages.
- Improved Network Settings UX with logical grouping, descriptive icons, and tooltips.
- Enhanced state visualization for DHCP-managed and readonly fields (e.g., MAC address).
- Updated sidebar tabs with real-time adapter status indicators.
- Refactored core types to use String for IP fields to handle hostnames (localhost) robustly.
- Verified all 67 E2E tests pass.

Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
@JanZachmann
fix(backend): prevent network rollback wait from blocking server rest…
cf2430e 
…arts

- Spawned process_pending_rollback as a concurrent background task to avoid blocking the main server loop during the rollback window.
- Updated process_pending_rollback signature to take ownership of the service client, satisfying 'static lifetime requirements for spawned tasks.
- Implemented Clone for MockDeviceServiceClient to support the new signature in unit tests.
- Added unit test to verify the new asynchronous, owned signature of process_pending_rollback.

Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
@JanZachmann
fix(core): extract detailed error context from backend response bodies
3ead5e1 
- Updated process_status_response and process_json_response to match on
  crux_http::HttpError::Http and extract the raw response body.
- Enhanced extract_error_message to return raw message bodies on success,
  ensuring detailed context from ODS reaches the UI.
- Consolidated error mapping logic into a shared map_http_error helper.
- Added a simple unit test for build_url in http_helpers.
- Created a new E2E test error-handling.spec.ts to verify the display
  of detailed error messages in the UI snackbar.
- Fixed minor indentation in backend network services.

Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
@JanZachmann
perf(backend): optimize firmware upload performance
684e048 
Implements streaming upload with performance optimizations:
- Align buffer sizes (512KB multipart + write buffer)
- Add periodic flushing (every 5MB or 10s)
- Set file permissions atomically
- Add stream timeout protection (30s/chunk, 600s total)
- Background folder clearing (non-blocking)
- Optimize worker threads for I/O-bound workload

Switch to pure-Rust crypto backends for stable cross-compilation:
- jwt-simple: optimal → pure-rust
- rustls: aws_lc_rs → ring

Remove verbose speed logging from firmware upload.

Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
@JanZachmann
feat(ui): redesign update page and unify action styles across all pages
cd9be35 
- Redesigned Update page with dynamic drag-and-drop area and 3-column info grid.
- Implemented auto-upload for firmware files.
- Unified primary action buttons to 'primary flat' style across all functional areas.
- Standardized dialog and secondary actions to 'primary text' or 'outlined' variants.
- Refined Reboot/Factory Reset buttons with compact density and fixed width.
- Updated Playwright E2E tests to match the new update flow and UI labels.
- Fixed backend cargo clippy warnings (manual_clamp and await_holding_lock).

Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
@JanZachmann
feat(ui): add modal popups for factory reset and update validation re…
7ce1e92 
…sults

Show persistent modal dialogs when factory reset completes or firmware
update validation finishes, ensuring the user sees the outcome regardless
of which page they navigate to after reboot.

- Factory reset result: Success (green) or Error (red) dialog with
  error details from the backend
- Update validation: Success for "Succeeded", Warning for "Recovered"
  (rollback to previous version)
- Dismissing a modal sends an ack to the backend (marker file in /tmp/)
  to suppress re-showing on page refresh
- Extract generic MarkerFile service from NetworkConfigService to
  cleanly separate network, factory reset, and update concerns

Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
@JanZachmann
fix(auth): extract token from set-password response for direct authen…
c9565fa 
…tication

After Keycloak redirect, the Core reinitializes with default state
(requires_password_set=false). The Vue watcher for auto-login depended
on a true->false transition that never occurred, leaving the user stuck
on the set-password dialog.

SetPasswordResponse now carries the auth token returned by the backend,
directly setting auth_token and is_authenticated. This eliminates the
fragile watcher-based auto-login and the unnecessary second HTTP
round-trip.

Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
@JanZachmann
fix(core): deserialize ODS factory reset status as integer
8310445 
ODS sends factory reset status as numeric values (0=ModeSupported,
1=ModeUnsupported, 2=BackupRestoreError, 3=ConfigurationError) but the
OdsFactoryResetResultStatus enum expected snake_case strings, causing
parse failure at runtime.

Switch to serde_repr for integer deserialization matching the ODS wire
format, and remove the unused OdsFactoryResetResultStatus from typegen
and Shell imports since it is an internal Core deserialization type.

Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
@JanZachmann
feat(ui): add countdown timer and cert hint to device operation overlays
1d7f978 
- Fix misleading update spinner texts: show "Installing update..." during
  POST (SWUpdate runs synchronously) and "Rebooting to new firmware" after
- Add countdown timer to reboot (5 min), factory reset (10 min), and update
  overlays with timeout constants defined in Core
- Unify timeout message with actionable cert re-acceptance hint
- Show "Open app in new tab" button on device operation timeout for cert
  re-acceptance (same pattern as network config changes)
- Make OverlaySpinner countdown label a prop ("Timeout in:" for device ops,
  "Automatic rollback in:" for network changes)
- Move overlay spinner sync before device/network state in sync.ts so
  watchers can read countdown value
- Remove dead reconnection_timeout_seconds field from Model

Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
@JanZachmann
fix(ui): use filled error buttons for destructive dialog actions
0cefa1d 
Change reboot and factory reset confirmation buttons from text variant
to flat variant with error color for better visibility and consistency
with the theme's VDangerButton pattern.

Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
@JanZachmann
chore(docker): remove unused COREPACK_ENABLE_DOWNLOAD_PROMPT env var
96cce21 
The dummy pnpm script on PATH preempts corepack entirely, making
this environment variable a no-op.

Signed-off-by: $(git config user.name) <$(git config user.email)>
@JanZachmann
chore(deps): update all workspace dependencies
b8cb8cb 
Rust major: reqwest 0.12→0.13 (rustls-tls→rustls), mockall 0.13→0.14
Rust minor/patch: actix-web, uuid, tokio, rustls, log, anyhow, etc.
UI major: @vueuse/core 13→14
UI minor/patch: vue, vuetify, axios, vite, biome, playwright, etc.

Fix jwt-simple 0.12.14 minimum key length enforcement in token tests.

Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
@JanZachmann
refactor(ui): align network page UX with device and update pages
3b73319 
- Standardize sub-section headers to text-subtitle-2 text-medium-emphasis
- Remove decorative prepend-inner icons from form fields
- Switch DHCP-managed fields to plain variant for read-only appearance
- Move MAC address to status bar as inline label matching Mode style
- Change form layout to horizontal rows per section
- Use text variant for secondary Discard button
- Remove redundant (current connection) chip
- Add UX Guidelines section to project-context.md
- Update e2e tests to match new DOM structure

Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
@JanZachmann
fix(ui): navigate to dashboard after successful password update
63dd206 
App.vue's global useMessageWatchers (flush: 'pre') cleared successMessage
before UpdatePassword's page-level watcher could react. Replace with
flush: 'sync' watchers that fire inline during the reactive assignment.

Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
@JanZachmann
fix(ui): display auth errors inline instead of as toasts
3f577dc 
Auth form errors were presented inconsistently: API errors (wrong
password) showed as toasts via the global useMessageWatchers, while
client-side validation errors (password mismatch) showed inline.

- Add `inlineErrors` route meta to suppress toast on auth pages
- Add `suppressErrorToast` option to useMessageWatchers composable
- Use flush:sync watchers in Login.vue and SetPassword.vue to capture
  errors before the global handler clears them
- Fix unauth_post/auth_post_basic macros losing HTTP response body text
  by using map_http_error instead of Display formatting on HttpError
- Add e2e tests for all auth error scenarios (inline display, no toast)

Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
@JanZachmann
chore(test): remove debug logging from e2e tests
aace5dc 
Signed-off-by: Jan Zachmann <50990105+JanZachmann@users.noreply.github.com>
@JanZachmann JanZachmann merged commit b81e1b7 into omnect:main Feb 9, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@JanZachmann

Comments