test: fix duplicate test name and migrate mocha.opts to .mocharc.json#39
Open
tedteddy wants to merge 1 commit intoomni-door:masterfrom
Open
test: fix duplicate test name and migrate mocha.opts to .mocharc.json#39tedteddy wants to merge 1 commit intoomni-door:masterfrom
tedteddy wants to merge 1 commit intoomni-door:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a test naming bug and modernizes the Mocha configuration.
Changes
1. Fix duplicate test name (Bug Fix)
In
src/commands/initial/__test__/index.test.ts, line 119 had a duplicate test name:Before:
After:
2. Migrate mocha.opts to .mocharc.json
The
mocha.optsfile format has been deprecated since Mocha 6.0.0. This PR:.mocharc.jsonwith the same configurationpackage.jsontest script to use the new configmocha.optsfileNew .mocharc.json:
{ "require": ["ts-node/register"], "spec": "src/**/__test__/*.ts", "reporter": "spec", "timeout": 10000 }Benefits