fix(security): prevent XSS injection in chatbot via unsafe innerHTML#21
Open
KGFCH2 wants to merge 1 commit into
Open
fix(security): prevent XSS injection in chatbot via unsafe innerHTML#21KGFCH2 wants to merge 1 commit into
KGFCH2 wants to merge 1 commit into
Conversation
The previous implementation used: chatBox.innerHTML += '<p><strong>You:</strong> ' + userInput + '</p>'; This allowed any user-typed HTML/script to execute directly in the DOM, creating a stored-like XSS vector within the session. Changes: - Add escapeHTML() helper using DOM's createTextNode() for safe encoding - Refactor appendMessage() to build DOM nodes instead of string concat - User messages rendered exclusively with textContent (no HTML execution) - Bot responses use innerHTML only for our own server-controlled content - Replace alert()/hard redirect on logout with clean localStorage.removeItem() - Add typing indicator while awaiting bot response (better UX) - Add Enter key support for submitting chat messages - Improve error messages with actionable guidance for users
|
@KGFCH2 is attempting to deploy a commit to the Om Roy's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #20
Summary
Replaces unsafe
innerHTML +=string concatenation in the chatbot with DOM node construction. User input is now rendered exclusively viatextContent, making it immune to XSS injection.Changes Made
escapeHTML()helper usingcreateTextNode()for safe encodingappendMessage()to build DOM nodes (no string HTML)textContentonly (neverinnerHTML)innerHTMLonly for server-controlled contentlocalStorage.removeItem()instead ofalert()+ redirectTesting
<img src=x onerror=alert(1)>renders as text, not executes<script>alert(1)</script>renders as literal textImpact
Eliminates an XSS vulnerability that could allow session token theft via the chat interface.
Checklist