Skip to content

AP-8425 # Added required properties to lookupButton form element #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
divporter merged 1 commit into from
May 8, 2026
Merged

AP-8425 # Added required properties to lookupButton form element #702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Added

- required properties to lookupButton form element

## [13.1.4] - 2026-05-07

### Added
Expand Down
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions src/lib/forms-schema/elements/LookupButtonElement.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import {
name,
label,
hint,
requiredSchemas,
conditionallyShowSchemas,
lookupSchemas,
customCssClasses,
Expand Down Expand Up @@ -32,6 +33,7 @@ export default Joi.object({
label,
hint,
hintPosition,
...requiredSchemas,
...conditionallyShowSchemas,
...lookupSchemas,
customCssClasses,
Expand Down
25 changes: 25 additions & 0 deletions tests/forms-schema/forms-schema.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7672,6 +7672,7 @@ describe('lookupButton form element', () => {
conditionallyShow: false,
isElementLookup: false,
elementDependencies: [],
required: false,
})
})

Expand Down Expand Up @@ -7766,6 +7767,7 @@ describe('lookupButton form element', () => {
dataLookupId: 1,
isElementLookup: false,
conditionallyShow: false,
required: false,
elementDependencies: [
{
elementId: '3A1916B9-B05A-46B5-A128-93639DE2D8ED',
Expand Down Expand Up @@ -7823,6 +7825,7 @@ describe('lookupButton form element', () => {
dataLookupId: 1,
isElementLookup: false,
conditionallyShow: false,
required: false,
elementDependencies: [
{
elementId: '3A1916B9-B05A-46B5-A128-93639DE2D8ED',
Expand Down Expand Up @@ -7884,6 +7887,7 @@ describe('lookupButton form element', () => {
dataLookupId: 1,
isElementLookup: false,
conditionallyShow: false,
required: false,
elementDependencies: [
{
elementId: '3A1916B9-B05A-46B5-A128-93639DE2D8ED',
Expand All @@ -7901,6 +7905,27 @@ describe('lookupButton form element', () => {
},
])
})

test('should accept "required" and "requiredMessage"', () => {
const result = validateFormThrowError({
...form,
elements: [
{
...lookupButtonElement,
required: true,
requiredMessage: 'Run the lookup before continuing',
},
],
})
expect(result.elements[0]).toEqual({
...lookupButtonElement,
conditionallyShow: false,
isElementLookup: false,
elementDependencies: [],
required: true,
requiredMessage: 'Run the lookup before continuing',
})
})
})

describe('ArcGISWebMapElement', () => {
Expand Down