Update cargo docs, update crate to version 0.3.0 for publishing#20
Merged
boydgreenfield merged 5 commits intomainfrom Oct 5, 2023
Merged
Update cargo docs, update crate to version 0.3.0 for publishing#20boydgreenfield merged 5 commits intomainfrom
boydgreenfield merged 5 commits intomainfrom
Conversation
boydgreenfield
force-pushed
the
boyd/docs-updates-for-publishing
branch
5 times, most recently
from
3bde349 to
87190b6
Compare
boydgreenfield
changed the title
boydgreenfield
force-pushed
the
boyd/docs-updates-for-publishing
branch
from
08ab537 to
4c80228
Compare
Contributor
Author
|
OK y'all already have a PR opened. 🤦♂️ onecodex/mmap-bitvec#20 Adding a regression test there and will work to get everything merged in and packaged up. |
boydgreenfield
force-pushed
the
boyd/docs-updates-for-publishing
branch
from
8925cfb to
047aaee
Compare
boydgreenfield
changed the title
… order isn't guaranteed)
List @Keats, @GSGerritsen, and @boydgreenfield as maintainers.
This fixes an issue introduced by rust-lang/rust#98112 in 1.70+ that otherwise breaks pointer dereferencing `mmap-bitvec`.
boydgreenfield
force-pushed
the
boyd/docs-updates-for-publishing
branch
from
1e4cb88 to
88bc3a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's currently an issue with
mmap-bitvecpointer dereferencing for 1.70+, which seems to relate to this change inrust1.70:(And here's another related issue). We'll need to:
mmap-bitvecmmap-bitvec@GSGerritsen I know you're out, but FYI I may have to ping you to add me on Cargo in order to publish a new version of
mmap-bitvecbecause I believe you're the only one with keys (maybe @Keats you have those too?).