Mitaka nfp 08 june 2016 oslo with perf#435
Open
mak-454 wants to merge 20 commits into
Open
Conversation
…plementation in orchestrator and full atf test cases
… and tested fw, lb, fw+lb. pending - ATF RUN
| context, network_function_id, operation='create') | ||
|
|
||
| # Check for NF status in a separate thread | ||
| gth = self.thread_pool.spawn(self._wait_for_network_function_operation_completion, |
|
Did we tested this with multiple prs ? |
| consumer_ports = None | ||
|
|
||
| if service_targets['consumer_pt_objs']: | ||
| consumer_pt = service_targets.get('consumer_pt_objs', [None])[0] |
There was a problem hiding this comment.
None never get executed, since we already checked with if.
Why we are doing different for both provider, consumer, Can we do in similar way
|
Can we remove all *_v1 functions ? |
| def _get_heat_client_v1(self, tenant_id, assign_admin=False): | ||
| if assign_admin: | ||
| try: | ||
| self._assign_admin_user_to_project(tenant_id) |
There was a problem hiding this comment.
Why we need new function ?
Except assign_admin variable, code is same with function _get_heat_client()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.