Script to build and configure nfp along with the required#583
Open
hemanthravi wants to merge 24 commits into
Open
Script to build and configure nfp along with the required#583hemanthravi wants to merge 24 commits into
hemanthravi wants to merge 24 commits into
Conversation
disk image builder scripts.
| git\ | ||
| rabbitmq-server\ | ||
| python-dev \ | ||
| screen |
There was a problem hiding this comment.
Don't we need 'vim' and 'unzip' package here ?
They are there in gbpservice/contrib/nfp/configurator/Dockerfile
>> Removed docker load from configurator user-data >> Detecting the operating system type (ubuntu/centos) and selecting proper path to get src_dirs >> Added cache dir support for image builder
| COPY ./neutron_lbaas /usr/local/lib/python2.7/dist-packages/neutron_lbaas | ||
| COPY ./configurator_run.sh /configurator_run.sh | ||
|
|
||
| # removing loadbalance v2 agent, driver, and paloalto fw driver |
There was a problem hiding this comment.
There will not be enterprise code in opensource installation. No need to remove these files. Remove following 3 lines.
>> Removed enterprise references from Dockerfile >> removed root-passwd from image builder
Addressed few pep8 warning
Fixed CIDRs for ip pools
>> removed unneeded 'git' package
>> removed unneeded 'git' package from Dockerfile
| --ip-version 4\ | ||
| --proxy-ip-pool=192.169.0.0/24\ | ||
| --ip-pool 120.0.0.0/24\ | ||
| --proxy-ip-pool=192.168.0.0/16\ |
Author
There was a problem hiding this comment.
Remove --proxy-ip-pool here. It's ok to pick the default (defined in ./neutron/extensions/driver_proxy_group.py)
of default. Otherwise ptg creation will fail due to an overlap of proxy-ip-pool for the implicitly created l3p.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
disk image builder scripts.
@njagadish @mabaig043 @rajendramachani @mak-454 @songole @rayalaman
The following needs to be done before submitting to openstack