🐛 Fix: Added a new props or a way to show selected filter.#187
Open
sarangshahane wants to merge 1 commit intoonesine:masterfrom
Open
🐛 Fix: Added a new props or a way to show selected filter.#187sarangshahane wants to merge 1 commit intoonesine:masterfrom
sarangshahane wants to merge 1 commit intoonesine:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hello @onesine & Team,
I am opening this PR to show the selected shortcut in the calendar dropdown. This is to make the date selector more UX-friendly so that users can see the selected shortcut/filter.
Here in this PR, I have added a way to show the selected shortcut in the calendar dropdown by comparing the stored value with the list of shortcodes.
The issue is reported here: #156
Here is the screenshot of the range filter after adding the class:
Note: Also, there were a few dependency issues while setting up the environment, the reason for them is mentioned below.
Reason for package.json file change
Reason for .eslintrc.json file change.
I hope this clarifies.
Please let me know if in case need more changes or discussion.
Looking forward to hearing from you.