feat: Add normalizing of input values that are missing delimiters#231
Open
tr3ysmith wants to merge 1 commit intoonesine:masterfrom
Open
feat: Add normalizing of input values that are missing delimiters#231tr3ysmith wants to merge 1 commit intoonesine:masterfrom
tr3ysmith wants to merge 1 commit intoonesine:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user puts in 03012024, currently now nothing happens, but with this change, as long as its a single date config, it'll add in the separators like 03/01/2024 so the date is parsed correctly. It depends on the display format and I supported the most common display formats.
MMDDYYYY
YYYYMMDD
DDMMYYYY
MMDDYY
YYMMDD
DDMMYY
And it doesn't care about the separator used in the display format.