first commit#8
Conversation
omrirz
left a comment
omrirz
left a comment
There was a problem hiding this comment.
General comment about tailwind.
you should do:
flex-col xl:flex-row
and not
mobile:flex-col xl:flex-row
mobile is the default.
| @@ -1,3 +0,0 @@ | |||
|
|
|||
| NEXT_DATOCMS_API_TOKEN= | |||
There was a problem hiding this comment.
Why deleting this file? How can a future developer know what he needs to put in his .env.local file?
| }, | ||
|
|
||
| screens: { | ||
| mobile: [{ min: '320px', max: '639px' }], |
There was a problem hiding this comment.
why do we need this "screens" section in the config? tailwind has it by default
There was a problem hiding this comment.
Removed screens and refactor classes.
| }, | ||
| extend: { | ||
| spacing: { | ||
| 20: '5rem', |
There was a problem hiding this comment.
what's the logic here of the key to value?
You don't use those values and tailwind has defaults that are enough for this:
https://tailwindcss.com/docs/customizing-spacing#default-spacing-scale
There was a problem hiding this comment.
Removed only the 20 value spacing. The reason is I needed more than 96 size for custom hight in some sections. I didn't use and jsx style.
2 participants
No description provided.