ADR: Revise interest curve utilization rate definition#303
Open
jordanschalm wants to merge 1 commit intomainfrom
Open
ADR: Revise interest curve utilization rate definition#303jordanschalm wants to merge 1 commit intomainfrom
jordanschalm wants to merge 1 commit intomainfrom
Conversation
zhangchiqing
reviewed
Apr 3, 2026
|
|
||
| ### Minimal Example | ||
| - User A deposits 100 units of X | ||
| - User B withdraws 100 units of X -> totalDebit(X) = 100 |
Member
There was a problem hiding this comment.
Suggested change
| - User B withdraws 100 units of X -> totalDebit(X) = 100 | |
| - User B withdraws (borrows) 100 units of X -> totalDebit(X) = 100 |
Comment on lines
+24
to
+25
| - User B deposits 105 units of X -> totalDebit(X) = 0 | ||
| - User B still owes 5 units of X, but totalDebit(X) = 0 |
Member
There was a problem hiding this comment.
Why B depositing 105 units would make totalDebit(X) to 0? Could you add more details in the comments.
| Prior to this ADR, protocol fees were computed as a percentage of estimated debit income, when extracted. Instead, we will compute protocol fees (insurance fee, stability fee) explicitly as the excess funds available in reserves. | ||
|
|
||
| ``` | ||
| protocolFee = reserveBalance + totalTrueDebitBalance - totalTrueCreditBalance |
Member
There was a problem hiding this comment.
Maybe more clear:
Suggested change
| protocolFee = reserveBalance + totalTrueDebitBalance - totalTrueCreditBalance | |
| IdleAmount = totalTrueCreditBalance - totalTrueDebitBalance | |
| protocolFee = reserveBalance - IdleAmount |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.